LMDZ6 Developers: lguez

Activity by Clock Time

Activity in Directories

Most Recent Commits

lguez 2022-09-29 21:19 Rev.: 4287

Bug fix: add count argument to `nf90_get_var`

Because, in the rico case, NetCDF variables which are read have
dimensions `(..., lat, lon)`, in NetCDF order, with lon = lat =
1. Without the count argument, for apbp for example, `nf90_get_var`
tried to read nlevel + 1 subscript values in the dimension lon, 1
subscript value in the lat dimension, and 1 subscript value in the
nlevp1 dimension: not what we want. I have checked that the cases
ARMCU/REF, amma and rico work with this revision.

5 lines of code changed in 1 file:

• trunk/libf/phylmd/dyn1d: mod_1D_cases_read2.F90 (+5 -3)

lguez 2022-09-21 15:12 Rev.: 4278

Correct paths to NetCDF-Fortran

The directory containing libraries from the Linux distribution is
included in the default directories searched by gfortran. Besides, it
is not /usr/local on Ubuntu on a personal computer, it is
/usr/lib/x86_64-linux-gnu. As for the include directory, it is
/usr/include on Ubuntu.

2 lines of code changed in 1 file:

• trunk/arch: arch-gfortran.path (+2 -2)

lguez 2022-09-21 15:12 Rev.: 4277

Link to NetCDF-Fortran library, not C library

The direct link from LMDZ is to the NetCDF-Fortran library, not the C
library. And as the NetCDF-Fortran library is dynamic in Linux
distributions, the link to the C library is not necessary.

0 lines of code changed in 1 file:

• trunk/arch: arch-gfortran.path (changed)

lguez 2022-09-21 15:12 Rev.: 4276

Remove useless include flags

These are paths to non-existent directories because FCM does not
compile from LMDZ top source directory.

0 lines of code changed in 1 file:

• trunk: makelmdz_fcm (-2)

lguez 2022-09-21 15:12 Rev.: 4275

Bug fix: remove comma before i/o item list

This was accepted by compilers as a legacy extension.

3 lines of code changed in 1 file:

• trunk/libf/phylmd/dyn1d: old_1D_read_forc_cases.h (+3 -3)

lguez 2022-09-21 15:12 Rev.: 4274

Replace `nf_get_var_type` by `nf90_get_var`

The immediate motivation is a bug fix: `nf_get_var_type` was called
with scalar resul3 or lat, lon, alt, phis instead of array actual
argument for dummy array argument rvals or dvals. Correcting this, we
might as well take the opportunity to use `nf90_get_var`, so we no
longer need to test `NC_DOUBLE` and we have half as many calls.

101 lines of code changed in 3 files:

• trunk/libf/phylmd/dyn1d: mod_1D_cases_read2.F90 (+16 -60), mod_1D_cases_read_std.F90 (+8 -30), old_1DUTILS_read_interp.h (+77 -359)

lguez 2022-09-21 15:12 Rev.: 4277

Link to NetCDF-Fortran library, not C library

The direct link from LMDZ is to the NetCDF-Fortran library, not the C
library. And as the NetCDF-Fortran library is dynamic in Linux
distributions, the link to the C library is not necessary.

0 lines of code changed in 1 file:

• trunk/arch: arch-gfortran.path (new)

lguez 2022-09-21 15:12 Rev.: 4273

Bug fix: split too long lines

The Fortran 2003 standard says a line may contain no more than 132
characters.

6 lines of code changed in 2 files:

• trunk/libf/phylmd/dyn1d: mod_1D_cases_read2.F90 (+2 -2), mod_1D_cases_read_std.F90 (+4 -3)

lguez 2022-09-21 15:12 Rev.: 4272

Indent the files

2345 lines of code changed in 2 files:

• trunk/libf/phylmd/dyn1d: mod_1D_cases_read2.F90 (+1278 -1278), mod_1D_cases_read_std.F90 (+1067 -1067)

lguez 2022-09-21 15:12 Rev.: 4271

Remove useless `&` at beginning of continued line

259 lines of code changed in 2 files:

• trunk/libf/phylmd/dyn1d: mod_1D_cases_read2.F90 (+143 -143), mod_1D_cases_read_std.F90 (+116 -116)

lguez 2022-09-20 16:09 Rev.: 4262

Bug fix: pass an array of integers as count

zklevo is real.

1 lines of code changed in 1 file:

• trunk/libf/phylmd: read_pstoke.F90 (+1 -1)

lguez 2022-09-20 16:09 Rev.: 4261

Bug fix: pass array argument to pfi of `gr_dyn_fi`

Dummy argument pfi in procedure `gr_dyn_fi` is an array. In procedure
`get_2Dfield`, we cannot associate the array element `champo(1, k)` to
pfi because champo is a pointer. The association of an array element
to an array is not allowed in this case.

1 lines of code changed in 1 file:

• trunk/libf/dynphy_lonlat/phylmd: limit_netcdf.F90 (+1 -1)

lguez 2022-09-20 16:09 Rev.: 4260

Bug fix: split too long lines

The Fortran 2003 standard says a line may contain no more than 132
characters.

34 lines of code changed in 5 files:

• trunk/libf/phylmd: cloudth_mod.F90 (+15 -5), fisrtilp.F90 (+6 -2), ice_sursat_mod.F90 (+3 -1), iophy.F90 (+7 -2), tracco2i_mod.F90 (+3 -1)

lguez 2022-09-20 16:09 Rev.: 4259

Replace `nf_put_vara_type` by `nf90_put_var`

The immediate motivation is a bug fix: `nf_put_vara_type` was called
with scalar instead of array actual arguments for dummy array
arguments start and count. Correcting this, we might as well take the
opportunity to use `nf90_put_var`, so we no longer need to test
`NC_DOUBLE` and we have half as many calls.

13 lines of code changed in 2 files:

• trunk/libf/dyn3d_common: grilles_gcm_netcdf_sub.F90 (+10 -31)
• trunk/libf/phylmd: iotd_ecrit.F90 (+3 -2)

lguez 2022-09-20 16:09 Rev.: 4258

Bug fix: correct varid

2 lines of code changed in 1 file:

• trunk/libf/dyn3d_common: grilles_gcm_netcdf_sub.F90 (+2 -2)

lguez 2022-09-20 16:09 Rev.: 4257

Bug fix: add missing argument ierr

2 lines of code changed in 2 files:

• trunk/libf/dyn3d_common: disvert.F90 (+1 -1)
• trunk/libf/dynphy_lonlat/phylmd: limit_netcdf.F90 (+1 -1)

lguez 2022-09-20 16:09 Rev.: 4256

Remove `include netcdf.inc`

They have become useless.

0 lines of code changed in 1 file:

• trunk/libf/dyn3d: guide_mod.F90 (-2)

lguez 2022-09-20 16:09 Rev.: 4255

Replace `nf_noerr` by `nf90_noerr`

We want to remove `include netcdf.inc`, eventually.

41 lines of code changed in 1 file:

• trunk/libf/dyn3d: guide_mod.F90 (+41 -40)

lguez 2022-09-20 16:09 Rev.: 4254

Replace `nf_get_vara_type` by `nf90_get_var`

The immediate motivation is a bug fix: `nf_get_vara_type` was called
with scalar instead of array actual arguments for dummy array
arguments start and count. Correcting this, we might as well take the
opportunity to use `nf90_get_var`, so we no longer need to test
`NC_DOUBLE` and we have half as many calls.

47 lines of code changed in 2 files:

• trunk/libf/dyn3d: guide_mod.F90 (+22 -84)
• trunk/libf/phylmd: read_pstoke.F90 (+25 -125)

lguez 2022-09-20 16:09 Rev.: 4253

Replace `nf_def_var` by `nf90_def_var`

The immediate motivation is a bug fix: `nf_def_var` was called with a
scalar instead of array actual argument for dummy array argument
vdims. The simplest way to correct this bug is to replace by a call to
`nf90_def_var`.

53 lines of code changed in 3 files:

• trunk/libf/dyn3d: guide_mod.F90 (+20 -20)
• trunk/libf/dyn3d_common: grilles_gcm_netcdf_sub.F90 (+12 -11)
• trunk/libf/phylmd: phyaqua_mod.F90 (+21 -20)

(86 more)